Hack around rebar3 compiling your project to output its version
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulo-ferraz-oliveira
force-pushed
the
fix/rebar-3-version-compilation
branch
4 times, most recently
from
3901b15 to
8ded306
Compare
What are we fixing? If you're with'ing "version-file": ".tool-versions" after you _use_ "actions/checkout", it's likely `rebar3` from `setup-beam` is compiling your project just to output its version This commit prevents that as per erlang/rebar3#2865 (comment)
paulo-ferraz-oliveira
force-pushed
the
fix/rebar-3-version-compilation
branch
from
8ded306 to
f2415ce
Compare
Comment on lines
+10721
to
+10724
| const env = { | ||
| REBAR_GLOBAL_CONFIG_DIR: '/fake-dir', | ||
| REBAR_CONFIG: 'fake.config', | ||
| } |
There was a problem hiding this comment.
This is the relevant change.
|
Release in v1.17.5. v1 and v1.17 moved to the same commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What are we fixing?
If you're
withing"version-file": ".tool-versions"after youuses"actions/checkout", it's likelyrebar3fromsetup-beamis compiling your project just to output itsversion.
This commit prevents that as per
erlang/rebar3#2865 (comment)