-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework our version matching algorithm #217
Merged
paulo-ferraz-oliveira
merged 20 commits into
erlef:main
from
paulo-ferraz-oliveira:feature/minor-tweaks
Jul 21, 2023
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7e372b1
Update some dependencies' versions (also, get rid of husky)
paulo-ferraz-oliveira 0724187
Introduce branch dependency execution
paulo-ferraz-oliveira b49c93c
Rid ourselves of bloat
paulo-ferraz-oliveira b324365
Introduce expectations for upcoming version
paulo-ferraz-oliveira 40fd5f4
Tweak whitespace
paulo-ferraz-oliveira 5cd8299
Tweak our calls to getVersionFromSpec (increase code consistency)
paulo-ferraz-oliveira ab34b3b
Remove non-used variable
paulo-ferraz-oliveira d562423
Start coercing on input, stop sorting/maybe prepending 'v' on input
paulo-ferraz-oliveira ca8049f
Revamp our getVersionFromSpec
paulo-ferraz-oliveira fa70a82
Reduce our expectations, but still be appropriate to our mission
paulo-ferraz-oliveira e06852f
Update our tests for our new expectations (start the TDD bit)
paulo-ferraz-oliveira 0a96fb1
Execute npm run build-dist and keep results
paulo-ferraz-oliveira 4960d20
Increase inter-job dependency
paulo-ferraz-oliveira 79a27d8
Don't expect markdownlint to be installed remotely
paulo-ferraz-oliveira 0f04e6e
Revert "Increase inter-job dependency"
paulo-ferraz-oliveira 3e94d49
Revert "Introduce branch dependency execution"
paulo-ferraz-oliveira b210439
Have all the CI workflows run under the same conditions
paulo-ferraz-oliveira bd45a7f
Fix as per CI results
paulo-ferraz-oliveira ebd8271
Re-establish the possibility to match versions like 22.3.4.2.1.0
paulo-ferraz-oliveira 6ba70af
Trim out linting practices
paulo-ferraz-oliveira File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,8 @@ on: | |
branches: | ||
- main | ||
pull_request: | ||
types: [opened, synchronize] | ||
branches: | ||
- main | ||
|
||
jobs: | ||
integration_test: | ||
|
@@ -111,12 +112,10 @@ jobs: | |
otp-version: '22.3.4.1' | ||
os: 'ubuntu-20.04' | ||
version-type: 'strict' | ||
- elixir-version: '1.10.3' | ||
otp-version: '22.3.4.1' | ||
os: 'ubuntu-20.04' | ||
Comment on lines
-114
to
-116
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We find this above, already, with |
||
- elixir-version: 'main' | ||
otp-version: '23.1' | ||
os: 'ubuntu-20.04' | ||
version-type: 'strict' | ||
- elixir-version: 'main' | ||
otp-version: '25' | ||
os: 'ubuntu-20.04' | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was moved to
package.json
which means this wholenpm ...
pipeline can simply be as it is proposed here.