Improve warnings about checkout dependencies when locking and upgrading #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsloughter
reviewed
Aug 28, 2020
src/rebar_prv_upgrade.erl
Outdated
| @@ -123,6 +125,8 @@ format_error({transitive_dependency, Name}) -> | |||
| io_lib:format("Dependency ~ts is transitive and cannot be safely upgraded. " | |||
| "Promote it to your top-level rebar.config file to upgrade it.", | |||
| [Name]); | |||
| format_error({checkout_dependency, Name}) -> | |||
| io_lib:format("Dependency ~ts is a checkout dependency and cannot be upgraded.", [Name]); | |||
There was a problem hiding this comment.
Suggested change
| io_lib:format("Dependency ~ts is a checkout dependency and cannot be upgraded.", [Name]); | |
| io_lib:format("Dependency ~ts is a checkout dependency under _checkouts/ and checkouts cannot be upgraded.", [Name]); |
tsloughter
requested changes
Aug 28, 2020
|
@tsloughter Neat, I thought of doing the same with the list comprehension but was unsure about how acceptable it was to add new functions to |
tsloughter
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2334.
Any feedback on the wording or how I am getting the checkout dependencies is welcome :)