Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing credits #2327

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Add missing credits #2327

merged 1 commit into from
Aug 21, 2020

Conversation

g-andrade
Copy link
Contributor

Today I've noticed that @lrascao , who contributed to earlier improvements to rebar3, is not part of the THANKS file.

This PR intends on changing that. He'll likely not care at all about this and consider it a pointless checkbox, but for such a small effort, I thought: "why not."

@ferd
Copy link
Collaborator

ferd commented Aug 21, 2020

Yep that's entirely fair and warranted!

@ferd ferd merged commit 7ccbc0b into erlang:master Aug 21, 2020
@lrascao
Copy link
Contributor

lrascao commented Aug 21, 2020

I am humbled and honoured, a hearty elbow bump to you all 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants