Abort when file:consult/1 returns an error in rebar3_hex_repos:auth_config/1 #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
starbelly
changed the title
|
Sounds reasonable, awaiting the test(s) |
starbelly
force-pushed
the
abort-on-auth-config-syntax-error
branch
from
141e4e2
to
ac59e14
Compare
starbelly
changed the title
|
@ferd Okie dokie, have a look at the test. The only way I can think of improving the test is capturing the output and/or not mock file:consult/1 and instead mock rebar_dir:global_config_dir/1 |
ferd
reviewed
Feb 20, 2019
|
Current tests seem fine. There's one call to unexport since it's unused. |
- Modified rebar_hex_repos:auth_config/1 to abort on error except in the case of enoent, in which we return an empty map. - added auth_config_errors test to test/rebar_pkg_repos_SUITE
starbelly
force-pushed
the
abort-on-auth-config-syntax-error
branch
from
ac59e14
to
6379510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the case of enoent, in which we return an empty map.
Example output for the two unhappy cases:
and
TODO: