Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingela/ssl/handle terminate alert/otp 19311 #8980

Conversation

IngelaAndin
Copy link
Contributor

@IngelaAndin IngelaAndin commented Oct 23, 2024

Fix bug also in older version of OTP when shutdown happens from the supervisor.
Solution will be piggybacked on other patches to OTP 26 and 25 eventually.

@IngelaAndin IngelaAndin requested review from dgud and u3s October 23, 2024 14:15
@IngelaAndin IngelaAndin self-assigned this Oct 23, 2024
@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

CT Test Results

    2 files     67 suites   48m 39s ⏱️
  800 tests   756 ✅  44 💤 0 ❌
3 774 runs  2 980 ✅ 794 💤 0 ❌

Results for commit f04ca2a.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin changed the base branch from master to maint October 23, 2024 14:16
@IngelaAndin IngelaAndin force-pushed the ingela/ssl/handle_terminate_alert/OTP-19311 branch from ccd7649 to ae49fe3 Compare October 23, 2024 17:44
Copy link
Contributor

@u3s u3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I speculate tc_api_profile fails because with this PR you've got more calls to terminate_alert/1 function and this results with more traces produced in api profile.

@IngelaAndin
Copy link
Contributor Author

I speculate tc_api_profile fails because with this PR you've got more calls to terminate_alert/1 function and this results with more traces produced in api profile.

@u3s Maybe we should provide a test update branch for that based on this branch as this branch is based on version where that test case does not exist.

@IngelaAndin IngelaAndin force-pushed the ingela/ssl/handle_terminate_alert/OTP-19311 branch from ae49fe3 to f04ca2a Compare October 25, 2024 08:29
@IngelaAndin
Copy link
Contributor Author

@u3s it seems easiest that I make a back-port branch for maint-25 where this test case does not exist.

@IngelaAndin IngelaAndin removed the request for review from dgud October 25, 2024 10:03
@IngelaAndin IngelaAndin merged commit 79d7951 into erlang:maint Oct 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants