-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingela/ssl/handle terminate alert/otp 19311 #8980
Ingela/ssl/handle terminate alert/otp 19311 #8980
Conversation
CT Test Results 2 files 67 suites 48m 39s ⏱️ Results for commit f04ca2a. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
ccd7649
to
ae49fe3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I speculate tc_api_profile fails because with this PR you've got more calls to terminate_alert/1
function and this results with more traces produced in api profile.
@u3s Maybe we should provide a test update branch for that based on this branch as this branch is based on version where that test case does not exist. |
ae49fe3
to
f04ca2a
Compare
@u3s it seems easiest that I make a back-port branch for maint-25 where this test case does not exist. |
Fix bug also in older version of OTP when shutdown happens from the supervisor.
Solution will be piggybacked on other patches to OTP 26 and 25 eventually.