Provide an overview of logger overload protection #8855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Digging into the topic of logger overload protection I found it somewhat hard to follow and keep track of what all the systems do on a high level. It probably doesn't solve this for everything, but I think providing a high level overview of the measures in place can help others to better understand the mechanisms and dive into the one they care the most about.
CT Test Results 2 files 70 suites 1h 4m 49s ⏱️ For more details on these failures, see this check. Results for commit 420d3f9. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
PragTob
added a commit
to PragTob/elixir
that referenced
this pull request
Sep 24, 2024
The previous docs didn't mention that logger may drop messages entirely, which I think is important to call out (and not just because I finished a long debugging journey to find these :) ). This should give a fair overview of the built-in overload protections, similar to what I tried to do in erlang/otp#8855 I think this can really help folks be aware of some of these.
|
Thanks! |
whatyouhide
pushed a commit
to elixir-lang/elixir
that referenced
this pull request
Sep 24, 2024
The previous docs didn't mention that logger may drop messages entirely. This should give a fair overview of the built-in overload protections, similar to erlang/otp#8855. --- Co-authored-by: Andrea Leopardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Digging into the topic of logger overload protection I found it somewhat hard to follow and keep track of what all the systems do on a high level.
It probably doesn't solve this for everything, but I think providing a high level overview of the measures in place can help others to better understand the mechanisms and dive into the one they care the most about.
Thank you all so much for your work 💚