Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
eriqua committed Oct 29, 2023
1 parent 03dfd23 commit 21724ca
Showing 1 changed file with 0 additions and 31 deletions.
31 changes: 0 additions & 31 deletions avm/res/batch/batch-account/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,6 @@ param publicNetworkAccess string = ''
@description('Optional. Network access profile. It is only applicable when publicNetworkAccess is not explicitly disabled.')
param networkProfile networkProfileType?

// @allowed([
// 'Allow'
// 'Deny'
// ])
// @description('Optional. The network profile default action for endpoint access. It is only applicable when publicNetworkAccess is not explicitly disabled.')
// param networkProfileDefaultAction string = 'Deny'

// @description('Optional. Array of IP ranges to filter client IP address. It is only applicable when publicNetworkAccess is not explicitly disabled.')
// param networkProfileAllowedIpRanges array?

@description('Optional. The lock settings of the service.')
param lock lockType

Expand Down Expand Up @@ -90,11 +80,6 @@ var identity = !empty(managedIdentities) ? {
userAssignedIdentities: !empty(formattedUserAssignedIdentities) ? formattedUserAssignedIdentities : null
} : null

// var networkProfileIpRules = !empty(networkProfile ?? {}) ? ([for ipRule in (networkProfile.ipRules ?? []): {
// action: 'Allow'
// value: ipRule
// }]) : null

var accountAccessNetworkProfileIpRules = [for allowedIpRule in networkProfile.?accountAccess.?allowedIpRules ?? []: {
action: 'Allow'
value: allowedIpRule
Expand Down Expand Up @@ -169,12 +154,6 @@ resource batchAccount 'Microsoft.Batch/batchAccounts@2022-06-01' = {
id: batchKeyVaultReference.id
url: batchKeyVaultReference.properties.vaultUri
} : null
// networkProfile: (publicNetworkAccess == 'Disabled') || empty(networkProfile ?? []) ? null : {
// accountAccess: {
// defaultAction: networkProfile.defaultAction
// ipRules: networkProfileIpRules
// }
// }
networkProfile: !empty(networkProfile ?? {}) ? {
accountAccess: !empty(accountAccessNetworkProfileIpRules) ? {
defaultAction: networkProfile.?accountAccess.?defaultAction
Expand Down Expand Up @@ -440,13 +419,3 @@ type endpointAccessProfileType = {
@description('Optional. Array of IP ranges to filter client IP address.')
allowedIpRules: array?
}?

// @allowed([
// 'Allow'
// 'Deny'
// ])
// @description('Optional. The network profile default action for endpoint access. It is only applicable when publicNetworkAccess is not explicitly disabled.')
// param networkProfileDefaultAction string = 'Deny'

// @description('Optional. Array of IP ranges to filter client IP address. It is only applicable when publicNetworkAccess is not explicitly disabled.')
// param networkProfileAllowedIpRanges array?

0 comments on commit 21724ca

Please sign in to comment.