Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RadioButtonGroup to allow setting an initialValue #35

Merged
merged 1 commit into from
Sep 1, 2016

Conversation

m14t
Copy link
Contributor

@m14t m14t commented Aug 30, 2016

Hi Erik,

First thank you for both redux-form and this wrapper library. I'm currently implementing a complex form that I need to know if it is "pristine" or not, and these libraries have been a huge time saver for me!

While working on this, I noticed that the initialValues were not getting set for RadioButtonGroup.

It turns out that this is because RadioButtonGroup expects the selected value to be passed in as valueSelected, not value.

This pull-request maps that value.

I tried to match your coding style as close as possible, but please leave me feedback, and I'll gladly make any changes you wish.

Thanks in advance!
-Matt

@erikras erikras merged commit 5477414 into erikras:master Sep 1, 2016
@m14t m14t deleted the radio-button-group-initial-value branch September 1, 2016 16:04
@m14t
Copy link
Contributor Author

m14t commented Sep 1, 2016

Thanks @erikras ! Would it be possible to get a tagged/npm release with these recent merges?

@m14t
Copy link
Contributor Author

m14t commented Oct 3, 2016

@erikras Sorry to pester, but it would still be great to see a release with the recent merges if possible.

Thanks again for all of your work here.

@erikras
Copy link
Owner

erikras commented Oct 3, 2016

Published in v4.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants