Use matching data text as search text #141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation expects an object as
value
when there's adataSourceConfig
. But the value is usually just a value, not an object containing the value and the text. So I believe when a value is provided and there's adataSourceConfig
the corresponding text should be looked up in thedataSource
.Maybe the case where the value is actually an object should be handled too, but I'm not sure it's a valid use case since the current behavior on change is to set only the value in the form data.