Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field height jumps when errors appear because of helperText #267

Open
Philipp91 opened this issue Jul 19, 2018 · 1 comment
Open

Field height jumps when errors appear because of helperText #267

Philipp91 opened this issue Jul 19, 2018 · 1 comment

Comments

@Philipp91
Copy link

A field without error and warning has no helperText set. In that case, material-ui's <TextField/> will not reserve any space for the helper text. When the field becomes validated and is invalid, the errorText is added and the height of the field increases. This leads to a visible jump in the page layout, which is especially bad if there are many invalid fields, or if it happens often as users click through the fields.

Any proper solution will have to reserve this space always, even when no error message is present. This leads to a less dense form. This was the default behavior with redux-form-material-ui 4.x and material-ui 0.x, but it broke with the new versions.

@arno-le
Copy link

arno-le commented Apr 11, 2019

Is this going to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants