-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea: exporting wrapped components #1
Comments
Those are good arguments against the "adapter" API, which was somewhat conceived in a late night coding binge. How about naming?
or just... import { RadioButtonGroup, TextField } from 'redux-form-material-ui';
import { RadioButton } from 'material-ui'; |
I would simply name it the way I will create a PR once I'll have some free time if you don't mind |
To be clear, you're voting for Option 3? import { RadioButtonGroup, TextField } from 'redux-form-material-ui';
import { RadioButton } from 'material-ui'; |
yep |
Great suggestion. Released as |
* Allow onChange from field in Slider.js (#1) Accept onChange function from declaration within <Field> component. * Complete slider refactor to allow onChange to be passed by Field, update example Form.js to show use
The flow would then become:
This allows for a better tree shaking with webpack2, is more explicit and less error prone in my opinion (no string component matching).
The text was updated successfully, but these errors were encountered: