Update to Babel 6 #778

psalz · 2016-01-06T17:21:16Z

I'm aware that there is another pull request for this (#730), but since its humongous, I wanted to share my take on it.

Note that the loose option was removed in Babel 6, so the output is expected to be different. There is an unofficial preset for loose ES2015, but I haven't checked it out yet.

Everything seems to be working as expected, except for the fact that issue #14 has re-emerged somehow (even with the underscore hack). However, running the respective command (e.g. npm run dev) a second time has always fixed it for me so far.

I also changed the way the build command is executed to ensure that everything within prod.config.js is running with NODE_ENV=production. This is for example required for Babel not to include the typecheck plugin within the build.

quicksnap · 2016-01-06T17:56:44Z

Thanks! I'm going to check this out--really appreciate it.

That underscore issue is really annoying..

strawbrary · 2016-01-07T05:41:34Z

Coincidentally, the ApiClient is not defined error should be fixed with the release of Node v5.4.0 today. There was a v8 bugfix they patched in which I think was related.

quicksnap · 2016-01-08T00:30:07Z

Do you have a link to info on that bugfix and/or how it relates? I'm curious..

strawbrary · 2016-01-08T01:32:05Z

@quicksnap: This was the original Babel issue: https://phabricator.babeljs.io/T2455
This issue was filed against v8 as a result: https://bugs.chromium.org/p/v8/issues/detail?id=4450
And this is the commit that landed it in node: nodejs/node@b4c51c5b76

I'm not exactly clear on the whole thing though since the v8 bug is about Unicode but the Babel issue has a repro that doesn't contain special Unicode characters...

isTravis · 2016-01-08T16:29:34Z

Thank you! These changes worked for my stack - which has been moderately altered from the beginning point of this boiler plate!

I did have a bunch of syntax that no longer worked though. It was simple enough to fix those - but I'm getting strange run-time bugs now - like Cannot read property 'setState' of undefined when calling this.setState() in my code. Do you know of any docs pointing out babel5>babel6 gotchas?

Edit: this.setState() bug was actually a promises bug because I was behind a few versions on some of my webpack npm modules were out of date (but didn't show up in the PR diff here because they were up to date for y'all). Thanks again! All is looking smooth - really appreciate the migration help!

mmahalwy · 2016-01-15T07:42:44Z

webpack/dev.config.js


 // Webpack config for development
 var fs = require('fs');
 var path = require('path');
 var webpack = require('webpack');
-var WebpackIsomorphicTools = require('webpack-isomorphic-tools');


hmm why was this removed? Not needed anymore?

Well, to my understanding the non-plugin version of webpack-isomorphic-tools is only required for server-side patching of the require function, which should be covered here.

But as it is not really related, I can squash and move this change as well as the (alphabetical) reordering of npm packages into a separate cleanup commit, should this be approved.

disbelief · 2016-02-03T02:51:10Z

I tried out this PR on a clean installation of react-redux-universal-hot-example and it works, but one caveat: Babel 6.4 requires a semi colon after class properties. This required trivial changes (added semicolons) to the following files:

    modified:   src/components/CounterButton/CounterButton.js
    modified:   src/components/InfoBar/InfoBar.js
    modified:   src/components/MiniInfoBar/MiniInfoBar.js
    modified:   src/components/SurveyForm/SurveyForm.js
    modified:   src/containers/About/About.js
    modified:   src/containers/App/App.js
    modified:   src/containers/Chat/Chat.js
    modified:   src/containers/Login/Login.js
    modified:   src/containers/LoginSuccess/LoginSuccess.js
    modified:   src/containers/Survey/Survey.js
    modified:   src/containers/Widgets/Widgets.js
    modified:   src/helpers/Html.js

flying-sheep · 2016-02-03T08:38:01Z

i’d rather use babel 6.3 until babel 6.5 (or 6.4.x) reverts that PR (as described in the PR)

josmardias · 2016-02-12T20:18:50Z

Which one has more chances to be merged, PR #759 or this one?

quicksnap · 2016-02-12T23:32:14Z

This one most likely, as it's much smaller.

flying-sheep · 2016-02-13T20:09:51Z

OK, 6.5.2 has it reverted!

josmardias · 2016-02-15T00:05:46Z

package.json

@@ -124,28 +140,26 @@
  },
  "devDependencies": {
    "autoprefixer-loader": "^3.1.0",
-    "babel-core": "~5.8.33",


why some packages were moved to from devDependencies to dependencies?

andrewmclagan · 2016-02-16T04:47:19Z

Any word on this babel 6 migration?

quicksnap · 2016-02-16T05:54:21Z

I personally would not like to merge until I've tested Babel 6 on my fork of the project (that is used at work).

If anyone out there is using these changes already, would love to hear feedback. I will probably try to migrate our project to Babel 6 sometime in the next few weeks.

I've spun up a test project and Babel 6 has been playing nicely. So long as the legacy-decorators thing works fine, I don't foresee any big issues 🎱

strawbrary · 2016-02-16T06:26:36Z

I've been using Babel 6 on my project for a month and it's been mostly smooth sailing. The transform-decorators-legacy plugin works great, the only issue I've run into is that export * from ... syntax is broken in Babel 6.

disbelief · 2016-02-16T16:04:22Z

I've been using Babel 6 with my project for a couple weeks now. I was seeing the ReferenceError: ApiClient is not defined bug (#14), but after upgrading node-js to version 5.6.0 (also released this week) this stopped happening as well. Otherwise, everything is working perfectly for me.

duro · 2016-02-16T16:53:11Z

I'm about to start a new project, I'd love to see this merged.

duro · 2016-02-16T17:43:22Z

@disbelief I got that same error. Upgrading to node 5 now.

andrewmclagan · 2016-02-16T21:56:20Z

I will be giving this a go later in the month.

ngduc · 2016-02-16T22:42:03Z

ditto: would love to see this merged. Thanks.

duro · 2016-02-17T00:13:32Z

I did a test merge locally of this branch into master, and after some easy conflict resolution, project ran just fine.

quicksnap · 2016-02-17T08:05:12Z

@psalz could you resolve the merge conflicts and I'll try to merge it in after giving it a whirl.

mmahalwy · 2016-02-18T08:26:36Z

May i suggest: https://github.com/danmartinez101/babel-preset-react-hmre

quicksnap · 2016-02-18T18:29:47Z

I haven't heard much of @psalz on this PR. If anyone else wants to open up a PR with his changes rebased, we can move forward.

quicksnap · 2016-02-18T18:30:24Z

(Not trying to rush you @psalz! Thanks for the work on this PR =)

josmardias · 2016-02-18T21:09:22Z

@quicksnap #935

Update to Babel 6 (replaces #778)

quicksnap · 2016-02-18T21:44:26Z

Closed by #935. Thanks @psalz and @josmardias!

andrewmclagan · 2016-02-18T22:08:31Z

@joshhunt appreciated..!

psalz · 2016-02-20T11:29:13Z

Thanks @josmardias

psalz added 2 commits January 6, 2016 17:56

update to babel 6

4764b94

ensure build runs in production environment

5027594

psalz force-pushed the babel-6 branch from 6487c82 to 5027594 Compare January 6, 2016 17:54

forgot babel-runtime

3c086e2

isTravis mentioned this pull request Jan 12, 2016

Upgrade to Babel v6 #488

Closed

thomasm0 mentioned this pull request Jan 13, 2016

Update babel to latest version (6) #817

Closed

mmahalwy reviewed Jan 15, 2016
View reviewed changes

bdefore mentioned this pull request Jan 16, 2016

Migration to redux simple router and async-props #833

Merged

josmardias reviewed Feb 15, 2016
View reviewed changes

josmardias mentioned this pull request Feb 18, 2016

Update to Babel 6 (replaces #778) #935

Merged

quicksnap added a commit that referenced this pull request Feb 18, 2016

Merge pull request #935 from josmardias/babel-6_

615dfcd

Update to Babel 6 (replaces #778)

quicksnap closed this Feb 18, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Babel 6 #778

Update to Babel 6 #778

psalz commented Jan 6, 2016

quicksnap commented Jan 6, 2016

strawbrary commented Jan 7, 2016

quicksnap commented Jan 8, 2016

strawbrary commented Jan 8, 2016

isTravis commented Jan 8, 2016

mmahalwy Jan 15, 2016

psalz Jan 17, 2016

psalz Jan 17, 2016

disbelief commented Feb 3, 2016

flying-sheep commented Feb 3, 2016

josmardias commented Feb 12, 2016

quicksnap commented Feb 12, 2016

flying-sheep commented Feb 13, 2016

josmardias Feb 15, 2016

andrewmclagan commented Feb 16, 2016

quicksnap commented Feb 16, 2016

strawbrary commented Feb 16, 2016

disbelief commented Feb 16, 2016

duro commented Feb 16, 2016

duro commented Feb 16, 2016

andrewmclagan commented Feb 16, 2016

ngduc commented Feb 16, 2016

duro commented Feb 17, 2016

quicksnap commented Feb 17, 2016

mmahalwy commented Feb 18, 2016

quicksnap commented Feb 18, 2016

quicksnap commented Feb 18, 2016

josmardias commented Feb 18, 2016

quicksnap commented Feb 18, 2016

andrewmclagan commented Feb 18, 2016

psalz commented Feb 20, 2016

Update to Babel 6 #778

Update to Babel 6 #778

Conversation

psalz commented Jan 6, 2016

quicksnap commented Jan 6, 2016

strawbrary commented Jan 7, 2016

quicksnap commented Jan 8, 2016

strawbrary commented Jan 8, 2016

isTravis commented Jan 8, 2016

mmahalwy Jan 15, 2016

Choose a reason for hiding this comment

psalz Jan 17, 2016

Choose a reason for hiding this comment

psalz Jan 17, 2016

Choose a reason for hiding this comment

disbelief commented Feb 3, 2016

flying-sheep commented Feb 3, 2016

josmardias commented Feb 12, 2016

quicksnap commented Feb 12, 2016

flying-sheep commented Feb 13, 2016

josmardias Feb 15, 2016

Choose a reason for hiding this comment

andrewmclagan commented Feb 16, 2016

quicksnap commented Feb 16, 2016

strawbrary commented Feb 16, 2016

disbelief commented Feb 16, 2016

duro commented Feb 16, 2016

duro commented Feb 16, 2016

andrewmclagan commented Feb 16, 2016

ngduc commented Feb 16, 2016

duro commented Feb 17, 2016

quicksnap commented Feb 17, 2016

mmahalwy commented Feb 18, 2016

quicksnap commented Feb 18, 2016

quicksnap commented Feb 18, 2016

josmardias commented Feb 18, 2016

quicksnap commented Feb 18, 2016

andrewmclagan commented Feb 18, 2016

psalz commented Feb 20, 2016