Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work on Windows #21

Closed
wants to merge 2 commits into from
Closed

Make it work on Windows #21

wants to merge 2 commits into from

Conversation

sderosiaux
Copy link

Hey,

I wanted to make it work on my Windows 8, it wasn't because of the NODE_PATH, here the fixes I did.
I don't know how to include that to make it work on both platforms at the same time, so don't merge it. I let you decide how to integrate it or just for people to find it.

You can see it's working as expected:

> npm run dev

> [email protected] dev C:\GitHub\react-redux-universal-hot-example
> node ./node_modules/concurrently/src/main.js --kill-others "npm run watch-client" "npm run start-dev"

[0]
[0] > [email protected] watch-client C:\GitHub\react-redux-universal-hot-example
[0] > SET NODE_PATH=./src && node webpack/webpack-dev-server.js
[0]
[1]
[1] > [email protected] start-dev C:\GitHub\react-redux-universal-hot-example
[1] > SET NODE_PATH=./src && SET "NODE_ENV=development" && node ./babel.server
[1]
[0] ==> �  Webpack development server listening on localhost:3001
[1] ==> ✅  Server is listening
[1] ==> �  React Redux Example Development running on port 3000, API on port 3030
[0] Hash: b7b9de4e9ea4bdd1b272
[0] Version: webpack 1.10.1
[0] Time: 4171ms
[0]                        Asset     Size  Chunks             Chunk Names
[0] main-b7b9de4e9ea4bdd1b272.js  2.85 MB       0  [emitted]  main

run start is working too.

What I needed to change:

  • SET in the commands of package.json to set the environment variables (some embedded in " to avoid a trailing space)
  • Fix few require paths that were not able to be resolved
  • Remove the class name ApiClient other I got that for some reasons :
    ReferenceError: ApiClient is not defined at new ApiClient (C:/GitHub/react-redux-universal-hot-example/src/ApiClient.js:15:22) at C:/GitHub/react-redux-universal-hot-example/src/server.js:37:18

@erikras
Copy link
Owner

erikras commented Jul 8, 2015

Thanks for sharing, @chtefi! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants