Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Theme-UI #1

Closed
wants to merge 3 commits into from
Closed

WIP: Theme-UI #1

wants to merge 3 commits into from

Conversation

erikdstock
Copy link
Owner

@erikdstock erikdstock commented Jul 4, 2019 •
edited
Loading

https://theme-ui.com/
https://github.com/system-ui/theme-ui

Please fill in this template.
Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@erikdstock erikdstock mentioned this pull request Jul 4, 2019
Closed
@erikdstock erikdstock changed the base branch from master to 0.8 July 4, 2019 16:35
@erikdstock erikdstock changed the base branch from 0.8 to master July 4, 2019 16:36
@erikdstock
Copy link
Owner Author

Regarding colors interface:
system-ui/theme-ui#156 (comment)

sebald
sebald reviewed Jul 10, 2019
View reviewed changes
types/theme-ui/package.json
"private": true,
"dependencies": {
"@emotion/core": "^10.0.14",
"@types/styled-system__css": "^5.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this should be styled-system/css? You can reference it in the path of tsconfig to make sure the correct and up to date package is used.

@erikdstock
Copy link
Owner Author

closing because this work got incorporated into DefinitelyTyped#37210

@erikdstock erikdstock closed this Nov 6, 2019
@erikdstock erikdstock deleted the theme-ui branch November 6, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebald sebald sebald left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikdstock @sebald