Using NMSLIB code from a release rather than from an obscure branch #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there a major impact? i can rerun benchmarks |
|
no impact (I checked). this is merely to ensure that the right version is used. |
maumueller
added a commit
to maumueller/ann-benchmarks-1
that referenced
this pull request
Oct 17, 2017
Only measure the time of the actual lookup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have retested NMSLIB using the updated version (which downloads v1.5). Seems to be fine. If you were waiting for an updated version to run SIFT benchmarks, you can run them now. Even faster with saved indices. We don't cheat and don't save answers there :-) Only the indices themselves.
Additionally, I changed the source location of convert_texmex_fvec.py (to be from NMSLIB v1.5 too). I sometimes rename folders, it's not a good idea to pull it from master. Really, on a second thought: ann_benchmark could probably keep its own copy of convert_texmex_fvec.py.