Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Basic validation of EIP-4844 transactions #992

Merged
merged 27 commits into from
Apr 19, 2023
Merged

core: Basic validation of EIP-4844 transactions #992

merged 27 commits into from
Apr 19, 2023

Conversation

yperbasis
Copy link
Member

@yperbasis yperbasis commented Apr 16, 2023

This PR introduces the new EIP-4844 transaction type with basic validation only. SSZ serialization and actual KZG commitment checks are not implemented yet (will be implemented in separate PRs later).

@yperbasis yperbasis added the cancun The Cancun protocol upgrade label Apr 16, 2023
@yperbasis yperbasis marked this pull request as ready for review April 18, 2023 14:43
@canepat
Copy link
Member

canepat commented Apr 18, 2023

@yperbasis I've added a SSZ encoding/decoding implementation in consensus_light_client that is a prototype branch and likely won't be merged as a whole; my plan is instead to split its changes into smaller PRs sooner or later.

@yperbasis
Copy link
Member Author

@yperbasis I've added a SSZ encoding/decoding implementation in consensus_light_client that is a prototype branch and likely won't be merged as a whole; my plan is instead to split its changes into smaller PRs sooner or later.

Cool, so we can add SSZ in a separate PR(s) later based on that.

Copy link
Member

@canepat canepat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yperbasis yperbasis merged commit 9589977 into master Apr 19, 2023
@yperbasis yperbasis deleted the eip-4844 branch April 19, 2023 14:21
@yperbasis yperbasis mentioned this pull request Jun 1, 2023
@yperbasis yperbasis mentioned this pull request Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cancun The Cancun protocol upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants