Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capi: fork validator fixes #2373

Merged
merged 19 commits into from
Oct 4, 2024
Merged

capi: fork validator fixes #2373

merged 19 commits into from
Oct 4, 2024

Conversation

JacekGlen
Copy link
Member

@JacekGlen JacekGlen commented Sep 20, 2024

The changes in this PR stem from testing tip execution in Erigon++. I tried to add unit test coverage, but some tests are difficult to setup. In any case Erigon has Silkworm CAPI tests that covers these scenarios.
Changes:

  • standardize the use of etl_mdbx::Collector - the pointer points to an object created on a function call and is deleted before the function returns
  • HashState::get_log_progress() is more resilient and can be called at any time
  • unify constructor setup for stages - delete copy and move constructors
  • access_layer can be called on the genesis block

@JacekGlen JacekGlen marked this pull request as ready for review September 20, 2024 15:07
@JacekGlen JacekGlen linked an issue Sep 26, 2024 that may be closed by this pull request
7 tasks
@canepat canepat self-requested a review October 4, 2024 12:21
@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Oct 4, 2024
@canepat canepat merged commit a4df03f into master Oct 4, 2024
6 checks passed
@canepat canepat deleted the capi-fork-validator-2 branch October 4, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block execution at the chain tip
2 participants