Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core, rpcdaemon: move gas+funds bailout mechanism into evm #2354

Merged
merged 6 commits into from
Sep 18, 2024
Merged

core, rpcdaemon: move gas+funds bailout mechanism into evm #2354

merged 6 commits into from
Sep 18, 2024

Conversation

bzawisto
Copy link
Contributor

@bzawisto bzawisto commented Sep 16, 2024 •
edited
Loading

Gas deduction and gas+funds validation are now part of evm (core).

@bzawisto bzawisto linked an issue Sep 16, 2024 that may be closed by this pull request
Move gas+funds bailout mechanism into EVM #2303
Closed
@bzawisto bzawisto marked this pull request as draft September 16, 2024 08:39
@bzawisto bzawisto marked this pull request as ready for review September 16, 2024 12:25
@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Sep 18, 2024
canepat
canepat approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@canepat canepat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It would be probably wise to move also the gas refunding happening at the end of EVMExecutor::call, given that it is related to the gas bailout as well. You can do it in another PR, maybe after addressing #2304

@canepat canepat changed the title Move gas+funds bailout mechanism into evm core, rpcdaemon: move gas+funds bailout mechanism into evm Sep 18, 2024
@canepat canepat merged commit 6cdb957 into master Sep 18, 2024
6 checks passed
@canepat canepat deleted the 2303-move-gas+funds-bailout-mechanism-into-evm branch September 18, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canepat canepat canepat approved these changes

Assignees
No one assigned
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move gas+funds bailout mechanism into EVM
2 participants
@bzawisto @canepat