Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcdaemon: fix eth_getStorageAt location as hex string index #2085

Merged
merged 6 commits into from
Jun 10, 2024
Merged

rpcdaemon: fix eth_getStorageAt location as hex string index #2085

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b66def
modify eth_getStorageAt using location as index not location_hash
lupin012 Jun 7, 2024
a9ca0dc
make fmt
web-flow Jun 7, 2024
a0fbcf7
crete exclude list for subtests
lupin012 Jun 9, 2024
238a85f
make fmt
web-flow Jun 9, 2024
74289a9
fix validation check
canepat Jun 10, 2024
573c423
do not skip negative tests
canepat Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions silkworm/rpc/commands/eth_api.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,15 +1093,22 @@ Task<void> EthereumRpcApi::handle_eth_get_transaction_count(const nlohmann::json

// https://eth.wiki/json-rpc/API#eth_getstorageat
Task<void> EthereumRpcApi::handle_eth_get_storage_at(const nlohmann::json& request, nlohmann::json& reply) {
auto params = request["params"];
if (params.size() != 3 || !is_valid_address(params[0].get<std::string>()) || !is_valid_hash(params[1].get<std::string>())) {
auto error_msg = "invalid eth_getStorageAt params: " + params.dump();
const auto& params = request["params"];
if (params.size() != 3 || !is_valid_address(params[0].get<std::string>())) {
const auto error_msg = "invalid eth_getStorageAt params: " + params.dump();
SILK_ERROR << error_msg;
reply = make_json_error(request, 100, error_msg);
co_return;
}
const auto address = params[0].get<evmc::address>();
const auto location = params[1].get<evmc::bytes32>();
const auto position = params[1].get<std::string>();
if (!is_valid_hex(position) || position.length() > 2 + kHashLength * 2) {
const auto error_msg = "invalid position in eth_getStorageAt params: " + params.dump();
SILK_ERROR << error_msg;
reply = make_json_error(request, 100, error_msg);
co_return;
}
const auto location = bytes32_from_hex(position);
const auto block_id = params[2].get<std::string>();
SILK_DEBUG << "address: " << address << " block_id: " << block_id;

Expand Down
Loading