-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpcdaemon: post EIP1559 balance check done on max_fee_per_gas and max_blob_per_gas #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lupin012
force-pushed
the
align_effective_gas_calc_to_erigon
branch
from
June 2, 2024 09:48
2272c8b
to
0b2a9c1
Compare
lupin012
changed the title
rpcdaemon: add check and modify effective_gas calc
rpcdaemon: add check on call according erigon
Jun 9, 2024
lupin012
force-pushed
the
align_effective_gas_calc_to_erigon
branch
from
June 12, 2024 18:05
fb9263e
to
edaf3d4
Compare
lupin012
force-pushed
the
align_effective_gas_calc_to_erigon
branch
from
June 13, 2024 08:09
6247988
to
060a135
Compare
lupin012
force-pushed
the
align_effective_gas_calc_to_erigon
branch
from
June 13, 2024 20:54
85cd2de
to
52d8c7b
Compare
lupin012
changed the title
rpcdaemon: add check on call according erigon
rpcdaemon: check on available balance on POSI EIP1559 should be done on max_fee_per_gas and max_blob_per_gas
Jun 13, 2024
lupin012
changed the title
rpcdaemon: check on available balance on POSI EIP1559 should be done on max_fee_per_gas and max_blob_per_gas
rpcdaemon: post EIP1559 check on balance should be done on max_fee_per_gas and max_blob_per_gas
Jun 13, 2024
canepat
added
the
maintenance
Some maintenance work (fix, refactor, rename, test...)
label
Jun 14, 2024
canepat
changed the title
rpcdaemon: post EIP1559 check on balance should be done on max_fee_per_gas and max_blob_per_gas
rpcdaemon: post EIP1559 balance check done on max_fee_per_gas and max_blob_per_gas
Jun 14, 2024
canepat
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally we always manage transactions using post EIP-1559 attributes i.e.
base_fee_per_gas
,max_fee_per_gas
,max_priority_fee_per_gas
, converting back and forth to/from pre EIP-1559gas_price
. Specifically:eth_call
), theCall
parameters are converted to post EIP-1559 format hererpc::EVMExecutor
relies only on post EIP-1559Transaction::effective_gas_price
to calculate the gas price and this works both pre and post EIP-1559max_fee_per_gas
(before we used the effective gas price)