Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: setup signal handling with SA_ONSTACK flag #1943

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

canepat
Copy link
Member

@canepat canepat commented Mar 27, 2024

This PR changes the implementation of SignalHandler to relying on sigaction system call on Linux and macOS platforms, so that we can use SA_ONSTACK flag on registered signal handlers.

Fixes #1940

@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Mar 27, 2024
Copy link
Member

@JacekGlen JacekGlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny change only. Looks good!

silkworm/infra/concurrency/signal_handler.cpp Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 53.34%. Comparing base (2eabf8a) to head (05aa102).
Report is 5 commits behind head on master.

Files Patch % Lines
silkworm/infra/concurrency/signal_handler.cpp 68.75% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1943   +/-   ##
=======================================
  Coverage   53.33%   53.34%           
=======================================
  Files         621      621           
  Lines       45881    45894   +13     
  Branches     7043     7044    +1     
=======================================
+ Hits        24470    24481   +11     
- Misses      19290    19295    +5     
+ Partials     2121     2118    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacekGlen JacekGlen merged commit 32e6dce into master Mar 28, 2024
15 checks passed
@JacekGlen JacekGlen deleted the ci/infra_fix_signal_handling_onstack branch March 28, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C API execute blocks: non-Go code set up signal handler without SA_ONSTACK flag
3 participants