Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: detect sublibraries #1905

Merged
merged 6 commits into from
Mar 14, 2024
Merged

cmake: detect sublibraries #1905

merged 6 commits into from
Mar 14, 2024

Conversation

battlmonstr
Copy link
Contributor

@battlmonstr battlmonstr commented Mar 11, 2024 •
edited
Loading

Automatically detect sublibraries with CMakeLists.txt based on cmake API:

get_directory_property(x SUBDIRECTORIES)
  • EXCLUDE_REGEX removed
  • LIBS_TEST removed: use an extra target_link_libraries call instead
  • NO_TEST option added to avoid hardcoding silkworm_capi special cases
  • explicitly pass PRIVATE dependencies of silkworm_capi_test, usual unit tests should not use PRIVATE dependencies by default

@battlmonstr battlmonstr mentioned this pull request Mar 12, 2024
Merged
@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Mar 14, 2024
@canepat canepat merged commit 41971cb into master Mar 14, 2024
4 of 5 checks passed
@canepat canepat deleted the pr/cmake_regex branch March 14, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canepat canepat canepat approved these changes

@lupin012 lupin012 Awaiting requested review from lupin012

Assignees
No one assigned
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@battlmonstr @canepat