sentry: fix unhandled exception in peer handshake close #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canepat
added
the
maintenance
battlmonstr
requested changes
Mar 11, 2024
| this->handshake_promise_.set_value(false); | ||
| try { | ||
| this->handshake_promise_.set_value(false); | ||
| } catch (const std::exception& e) { |
There was a problem hiding this comment.
what kind of exception is thrown and why?
is it possible to avoid a "catch all" and "ignore" here?
There was a problem hiding this comment.
It's a std::runtime_error we raise in AwaitableFuture::set when AsyncChannel::try_send returns false (i.e. not sent) and the channel is still open. We definitely can investigate this issue more and probably have a better fix, but I propose to do this in next PR on the subject.
Maybe we can keep #1896 open and you can put it on your todo list, if you agree.
battlmonstr
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1896