db: decouple db module #1885
Merged
db: decouple db module #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
battlmonstr
commented
Mar 6, 2024
battlmonstr
commented
- move access_layer Account test
- refactor EthStatusDataProvider, move it to sentry
- add silkworm_db library target
- cleanup silkworm_rpcdaemon cmake script, it doesn't depends on silkworm_node now 🎉
- cleanup some cmds to not depend on silkworm_node
* move access_layer Account test
JacekGlen
approved these changes
Mar 7, 2024
| silkworm_db | ||
| PUBLIC ${LIBS_PUBLIC} | ||
| PRIVATE ${LIBS_PRIVATE} | ||
| EXCLUDE_REGEX "db/etl" |
There was a problem hiding this comment.
Suggested change
| EXCLUDE_REGEX "db/etl" | |
| EXCLUDE_REGEX "etl" |
not sure about it, can you double check?
There was a problem hiding this comment.
EXCLUDE_REGEX is a temporary hack to exclude sub-libraries. The plan is to detect them automatically and exclude their subfolders from the sources list. It's on my TODO list ✍️
| if (head_total_difficulty) { | ||
| head_info.total_difficulty = head_total_difficulty.value(); | ||
| } else { | ||
| log::Warning("db::HeadInfo") << "total difficulty of canonical hash at height " << std::to_string(head_height) << " not found in db"; |
There was a problem hiding this comment.
We should log the warning only in cases when total difficulty is required
There was a problem hiding this comment.
I agree. This function should probably be refactored to not log, but return optional values in these fields. Then we can check them and log on the call site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.