-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade grpc to 1.54.3 #1619
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
battlmonstr
added
the
maintenance
Some maintenance work (fix, refactor, rename, test...)
label
Jun 7, 2024
battlmonstr
force-pushed
the
ci/update_grpc2
branch
6 times, most recently
from
June 12, 2024 14:54
3b4a6d8
to
1e5a192
Compare
co_spawn is fixed in boost 1.83 see chriskohlhoff/asio#1332
AwaitableFuture::get blocks in tests, because async_receive task io_context is not polled, and the future wrapping the task does not make progress.
fixes: ld: warning: object file (third_party/blst/blst/libblst.a[2](assembly.o)) was built for newer 'macOS' version (14.0) than being linked (13.3)
fixes: ld: warning: object file (.../lib/libboost_iostreams.a[6](zlib.o)) was built for newer 'macOS' version (14.0) than being linked (13.3) ld: warning: object file (.../lib/libboost_thread.a[2](thread.o)) was built for newer 'macOS' version (14.0) than being linked (13.3) ld: warning: object file (.../lib/libboost_thread.a[3](once.o)) was built for newer 'macOS' version (14.0) than being linked (13.3) see: conan-io/conan-center-index#12328 conan-io/conan-center-index#20492 conan-io/conan-center-index#10281
battlmonstr
force-pushed
the
ci/update_grpc2
branch
from
June 14, 2024 14:17
1e5a192
to
4513a18
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1619 +/- ##
==========================================
- Coverage 53.77% 53.64% -0.13%
==========================================
Files 660 660
Lines 46723 46586 -137
Branches 7163 7156 -7
==========================================
- Hits 25125 24991 -134
- Misses 19381 19385 +4
+ Partials 2217 2210 -7 ☔ View full report in Codecov by Sentry. |
battlmonstr
force-pushed
the
ci/update_grpc2
branch
from
June 14, 2024 15:45
4513a18
to
fe9c4f5
Compare
canepat
approved these changes
Jun 17, 2024
lupin012
pushed a commit
that referenced
this pull request
Jun 18, 2024
Co-authored-by: battlmonstr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
57d4b96 build: upgrade grpc to 1.54.3 (#2079)
Update asio-grpc, boost, grpc, protobuf, abseil, zlib, openssl to the latest compatible versions for which prebuilt binaries are available on conancenter.
647988a interfaces cmake: create OUT_PATH directory if missing
To fix clean/regenerate.
Find correct PROTOBUF_PROTOC if multiple present (and the old was cached).
99dc7ed update generated GRPC interfaces
4537b14 remove custom co_spawn implementation
co_spawn is fixed in boost 1.83
see chriskohlhoff/asio#1332
1b06787 fix AwaitableFuture::get blocking
AwaitableFuture::get blocks in tests, because async_receive task io_context is not polled,
and the future wrapping the task does not make progress.
1a7ae11 pass macosx-version-min for libblst.a
74ffda7 pass macosx-version-min for boost
see:
conan-io/conan-center-index#12328
conan-io/conan-center-index#20492
conan-io/conan-center-index#10281
b412051 update cmake-conan to b240c8@develop
for CONF support
27a65af cmake: build conan libs with sanitizer options
fixes abseil/abseil-cpp#1524
fe9c4f5 disable failing tests with SILKWORM_SANITIZE
skip a problematic test on macOS