Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade grpc to 1.54.3 #1619

Merged
merged 12 commits into from
Jun 17, 2024
Merged

build: upgrade grpc to 1.54.3 #1619

merged 12 commits into from
Jun 17, 2024

Conversation

yperbasis
Copy link
Member

@yperbasis yperbasis commented Oct 29, 2023

Changes:

57d4b96 build: upgrade grpc to 1.54.3 (#2079)

Update asio-grpc, boost, grpc, protobuf, abseil, zlib, openssl to the latest compatible versions for which prebuilt binaries are available on conancenter.

647988a interfaces cmake: create OUT_PATH directory if missing

To fix clean/regenerate.
Find correct PROTOBUF_PROTOC if multiple present (and the old was cached).

99dc7ed update generated GRPC interfaces

4537b14 remove custom co_spawn implementation

co_spawn is fixed in boost 1.83
see chriskohlhoff/asio#1332

1b06787 fix AwaitableFuture::get blocking

AwaitableFuture::get blocks in tests, because async_receive task io_context is not polled,
and the future wrapping the task does not make progress.

1a7ae11 pass macosx-version-min for libblst.a
74ffda7 pass macosx-version-min for boost

see:
conan-io/conan-center-index#12328
conan-io/conan-center-index#20492
conan-io/conan-center-index#10281

b412051 update cmake-conan to b240c8@develop

for CONF support

27a65af cmake: build conan libs with sanitizer options

fixes abseil/abseil-cpp#1524

fe9c4f5 disable failing tests with SILKWORM_SANITIZE

skip a problematic test on macOS

@yperbasis yperbasis marked this pull request as draft October 29, 2023 11:50
@battlmonstr battlmonstr mentioned this pull request Jun 6, 2024
@battlmonstr battlmonstr added the maintenance Some maintenance work (fix, refactor, rename, test...) label Jun 7, 2024
@battlmonstr battlmonstr force-pushed the ci/update_grpc2 branch 6 times, most recently from 3b4a6d8 to 1e5a192 Compare June 12, 2024 14:54
yperbasis and others added 9 commits June 14, 2024 12:33
AwaitableFuture::get blocks in tests, because async_receive task io_context is not polled,
 and the future wrapping the task does not make progress.
fixes:
ld: warning: object file (third_party/blst/blst/libblst.a[2](assembly.o)) was built for newer 'macOS' version (14.0) than being linked (13.3)
fixes:
ld: warning: object file (.../lib/libboost_iostreams.a[6](zlib.o)) was built for newer 'macOS' version (14.0) than being linked (13.3)
ld: warning: object file (.../lib/libboost_thread.a[2](thread.o)) was built for newer 'macOS' version (14.0) than being linked (13.3)
ld: warning: object file (.../lib/libboost_thread.a[3](once.o)) was built for newer 'macOS' version (14.0) than being linked (13.3)

see:
conan-io/conan-center-index#12328
conan-io/conan-center-index#20492
conan-io/conan-center-index#10281
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.

Project coverage is 53.64%. Comparing base (c398249) to head (2b3523a).

Files Patch % Lines
silkworm/node/stagedsync/execution_engine.cpp 20.00% 8 Missing ⚠️
silkworm/infra/concurrency/awaitable_future.hpp 0.00% 3 Missing ⚠️
silkworm/rpc/http/connection.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1619      +/-   ##
==========================================
- Coverage   53.77%   53.64%   -0.13%     
==========================================
  Files         660      660              
  Lines       46723    46586     -137     
  Branches     7163     7156       -7     
==========================================
- Hits        25125    24991     -134     
- Misses      19381    19385       +4     
+ Partials     2217     2210       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@battlmonstr battlmonstr marked this pull request as ready for review June 14, 2024 16:33
@canepat canepat merged commit 8b45d35 into master Jun 17, 2024
14 of 15 checks passed
@canepat canepat deleted the ci/update_grpc2 branch June 17, 2024 10:19
lupin012 pushed a commit that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: SIGSEGV from absl::flat_hash_map::insert()
3 participants