-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No pointer optimisation txn #142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
master
txn.val replacement (branch no-pointer-optimisation-txn) |
compared benchmark of txn.val pointer (like in master) and non-pointer (this update) |
AskAlexSharov
added a commit
to erigontech/erigon
that referenced
this pull request
Jun 13, 2024
Implementation of this PR in mdbx-go erigontech/mdbx-go#142 to check CI --------- Co-authored-by: Ilya Miheev <[email protected]> Co-authored-by: alex.sharov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optimization that changed txn.val to non-pointer that allows us to avoid cgoCheckUnknownPointer false-positive cgo behavior.
CI Check in Erigon: erigontech/erigon#10708