Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor payload building #3592

Merged
merged 16 commits into from
Feb 23, 2022
Merged

Refactor payload building #3592

merged 16 commits into from
Feb 23, 2022

Conversation

yperbasis
Copy link
Member

@yperbasis yperbasis commented Feb 23, 2022 •
edited
Loading

  1. Ensure that, when we're building a payload, our current state matches headBlockHash of the corresponding forkchoiceUpdated.
  2. Use empty (no txns) but valid blocks to initialize pending payloads. They serve as fallback in case we fail to actually build a block with transactions.

@yperbasis yperbasis added the proof-of-stake "The Merge" related commits label Feb 23, 2022
@yperbasis yperbasis mentioned this pull request Feb 23, 2022
Closed
10 tasks
@yperbasis yperbasis marked this pull request as draft February 23, 2022 15:39
@yperbasis yperbasis marked this pull request as ready for review February 23, 2022 16:38
@yperbasis yperbasis merged commit 37ccbc5 into devel Feb 23, 2022
@yperbasis yperbasis deleted the kiln_stuff_4 branch February 23, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeyAkhunov AlexeyAkhunov AlexeyAkhunov approved these changes

@Giulio2002 Giulio2002 Awaiting requested review from Giulio2002

@AskAlexSharov AskAlexSharov Awaiting requested review from AskAlexSharov

Assignees
No one assigned
Labels
proof-of-stake "The Merge" related commits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yperbasis @AlexeyAkhunov