Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stage_finish.go : notifications to rpc daemon #2755

Merged
merged 8 commits into from
Oct 4, 2021
Merged

Update stage_finish.go : notifications to rpc daemon #2755

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e0e7e7a
Update stage_finish.go
AndreaLanfranchi Sep 30, 2021
c21011f
Notify at most 1024 headers
AndreaLanfranchi Oct 2, 2021
cd8ddfd
Update stage_finish.go
AndreaLanfranchi Oct 2, 2021
a822f39
Simplify return
AndreaLanfranchi Oct 2, 2021
325ed1e
Check for nil on notifications before notifications.Accumulator
AndreaLanfranchi Oct 2, 2021
ce7d90b
Notify all headers
AndreaLanfranchi Oct 2, 2021
ebc8287
Amend ineffectual assignment
AndreaLanfranchi Oct 2, 2021
2f98baf
Capture highest header number
AndreaLanfranchi Oct 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion eth/stagedsync/stage_finish.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,11 @@ func NotifyNewHeaders(ctx context.Context, finishStageBeforeSync uint64, unwindT
return nil
}

for i := notifyFrom; i <= notifyTo; i++ {
i := notifyFrom
if notifyTo-notifyFrom > 1024 {
i = notifyTo
}
for ; i <= notifyTo; i++ {
header := rawdb.ReadHeaderByNumber(tx, i)
if header == nil {
return fmt.Errorf("could not find canonical header for number: %d", i)
Expand Down