-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Improve RLP encode/decode core types #12579
base: main
Are you sure you want to change the base?
Conversation
Moved RLP logic in core types to separate file |
Moved often used rlp functions from ./rlp/encode to ./erigon-lib/rlp/encode |
|
With reflection-based, on Log struct only |
let me test it against rlpgen |
RLPgen: 492243439 48.56 ns/op 0 B/op 0 allocs/op We should move towards rlpgen, if no objections, didn't know what that is :) |
Silkworm based approach + reusable buffer: 667179529 35.36 ns/op 0 B/op 0 allocs/op |
This PR will fix RLP related issues, removing some unused parts and improving some other parts of the code. Benchmarks on Log type encoding/decoding shows that it makes sense to keep using hand-written code.