Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/types: disable go:generate codecgen for receipts and logs #10105

Merged
merged 3 commits into from
Apr 30, 2024
Merged

core/types: disable go:generate codecgen for receipts and logs #10105

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcb974d
core/types: fix codecgen for go1.22
taratorio Apr 28, 2024
7824fc0
disable codecgen for logs and receipts
taratorio Apr 29, 2024
9bf784d
Merge branch 'devel' of github.com:ledgerwatch/erigon into fix-codecg…
taratorio Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions core/types/receipt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,25 @@ import (
"bytes"
"errors"
"fmt"
"github.com/ledgerwatch/erigon-lib/common/hexutil"
"io"
"math/big"

libcommon "github.com/ledgerwatch/erigon-lib/common"
"github.com/ledgerwatch/erigon-lib/common/hexutil"
"github.com/ledgerwatch/erigon-lib/common/hexutility"

"github.com/ledgerwatch/erigon/crypto"
"github.com/ledgerwatch/erigon/rlp"
)

// go:generate gencodec -type Receipt -field-override receiptMarshaling -out gen_receipt_json.go
//go:generate codecgen -o receipt_codecgen_gen.go -r "^Receipts$|^Receipt$|^Logs$|^Log$" -st "codec" -j=false -nx=true -ta=true -oe=false -d 2 receipt.go log.go

// disabling codecgen generation since it does not work for go1.22
// to get it working need to update github.com/ugorji/go/codec to v1.2.12 which has the fix:
// - https://github.com/ugorji/go/commit/8286c2dc986535d23e3fad8d3e816b9dd1e5aea6
// however updating the lib has caused us issues in the past, and we don't have good unit test coverage for updating atm
// we also use this for storing Receipts and Logs in the DB - we won't be doing that in Erigon 3
// do not regen, more context: https://github.com/ledgerwatch/erigon/pull/10105#pullrequestreview-2027423601
// go:generate codecgen -o receipt_codecgen_gen.go -r "^Receipts$|^Receipt$|^Logs$|^Log$" -st "codec" -j=false -nx=true -ta=true -oe=false -d 2 receipt.go log.go

var (
receiptStatusFailedRLP = []byte{}
Expand Down
Loading