eth/tracers: always pop precompiles stack in callTracer (#11004) (#11024

) cherry pick: 1a050db for E3 --- made a mistake in previous PR #11022 should always pop the precompiles stack for correctness
erigontech · Jul 4, 2024 · cfb55a3 · cfb55a3
1 parent 2711926
commit cfb55a3
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/eth/tracers/native/call.go b/eth/tracers/native/call.go
@@ -254,8 +254,13 @@ func (t *callTracer) CaptureExit(output []byte, gasUsed uint64, err error) {
 		return
 	}
 	precompilesLastIdx := len(t.precompiles) - 1
-	if !t.config.IncludePrecompiles && precompilesLastIdx > -1 && t.precompiles[precompilesLastIdx] {
-		t.precompiles = t.precompiles[:precompilesLastIdx]
+	if precompilesLastIdx < 0 {
+		return
+	}
+	// pop precompile
+	precompile := t.precompiles[precompilesLastIdx]
+	t.precompiles = t.precompiles[:precompilesLastIdx]
+	if precompile && !t.config.IncludePrecompiles {
 		return
 	}
 	// pop call