Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix garbled file's title on leftfovers. #63

Merged

Conversation

fossamagna
Copy link
Contributor

When file's title on leftovers contains multi-bytes character,
copied file's title was garbled.
Drive.Files.get(id, {alt: 'media'}) cannot specify content encoding.
The content encoding is expected UTF-8.
So, getBlob().getDataAsString() Instead of Files.get().

When file's title on leafovers containts multi-bytes charactor,
copied file's title was garbled.
`Drive.Files.get(id, {alt: 'media'})` cannot specify content encoding.
The content encoding is expected UTF-8.
So, `getBlob().getDataAsString()` Instead of `Files.get()`.
@ericyd
Copy link
Owner

ericyd commented Dec 20, 2018

First, let me say thank you for contributing!

Second, what functional change does this achieve? Are you getting garbled file names during the copy process or is it just the "leftovers" file you're trying to fix. I'm less inclined to introduce changes if its just the leftovers file - the titles in that file are not used after the top-level folder is created.

@ericyd
Copy link
Owner

ericyd commented Dec 20, 2018

Nevermind my second comment, I realized where this is used. Let me try to find some time this weekend to do some testing and make sure this doesn't break anything so I can get this merged.

@ericyd ericyd merged commit bfca94c into ericyd:master Jan 6, 2019
@ericyd
Copy link
Owner

ericyd commented Jan 6, 2019

Merged and deployed!

Thanks for contributing. Sorry it took me so long to review, the holidays got really busy at work and personally. I appreciate the fix, though - I believe this was the underlying bug behind #49 but I wasn't able to reproduce previously. Now it is fixed for good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants