path/filepath: fix EvalSymLink documentation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This documentation change is the best solution for EvalSymLinks short of deleting this API altogether. EvalSymLinks is not suitable on any operating system because it unconditionally undoes indirections without being aware of the problems that these indirections solve. This is a violation of the software engineering principle which states: > Any problem in software can be solved by adding another layer of indirection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documentation change is the best solution for EvalSymLinks short of deleting this API altogether.
EvalSymLinks is not suitable on any operating system because it unconditionally undoes indirections without being aware of the problems that these indirections might solve.
This is a violation of what Wikipedia calls the "Fundamental Theorem of Software Engineering" (https://en.wikipedia.org/wiki/Fundamental_theorem_of_software_engineering). In my own words:
This is the poor mans solution to golang#40104 until go might introduce suitable alternatives and/or break EvalSymLinks current behavior.