Fix Router Access page #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n3vu0r
changed the title
* Restart firewall on demand.
* Restart uhttpd on demand.
* Refresh page on demand, with delay when uhttpd is restarted.
* Detect if uhttpd is used as a reverse proxy's backend and avoid redirect.
* Support uhttpd's redirect_https as another HTTP -> HTTPS protocol option.
* If enabled, sets remote web port field read-only with dashed border and
updates it when local web port changes. (New common.js functions)
* Order protocols by security and preselect the next more secure one when
previously selected remote protocol is no option with new local protocol.
* Reset proofread color when resetting page. (New common.js function)
* Reset disabled color instead of setting it to black when enabling element.
* Support uhttpd's rfc1918_filter as checkbox with unchanged default being on.
* Detect access area (LAN/WAN or local/remote) to warn when about to lock out.
* Warn when about to lock out from remote web access.
* If affected by disabling remote access.
* If affected by enabling RFC 1918 filter. (New common.js functions)
* Warn when about to lock out from local/remote web access.
* On unfit protocol change if uhttpd is used as a reverse proxy's backend.
* Show access chain of domains and IP addresses as part of warnings.
* Add dividers before remote web, common web, and remote SSH settings.
* Add missing visibility initialization of SSH help.
* Avoid failing double initialization of help visibility when resetting page.
* Use smooth scrollIntoView(alignToTop = false) instead of jumpy hashtag.
lantis1008
suggested changes
Feb 27, 2020
|
Also your other code changes will go in this weekend, have not forgotten. |
added 4 commits
February 28, 2020 14:59
Overwrites bootstrap and can again be overwritten by themes.
|
Thanks. Just a reminder, preferably new changes go into master, as that is where the future of Gargoyle lies. |
|
Good to know, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update UCI after saving changes w/o redirect
In contrast to
basic.js,access.jsmisses to updateuciOriginalafter saving changes without redirect. Resetting data afterwards results in disabling allremote_accepts (Remote Web Access and Remote SSH Access) because when saving changes, the old firewall sections are deleted fromuciOriginalbefore it is cloned intoucito which the new firewall sections are added. But in the end,uciOriginalmust be updated toucito reflect all the changes including the new firewall sections.Found some other issues, more commits coming.