[Refactor + Fix]: Code Reorganization #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 21, 2021 14:30
- bye yarn - moves code out of giant index.js into smaller files - adds tests/bir-vue (Vue CLI vanilla) for local testing - updates CONTRIBUTING - adds LICENSE
- adds "dev" script for easier local dev - code for bir-vue - no more global img or canvas, it's all local
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm going to "self high five" merge this, but I wanted to outline the main changes in this PR
Refactored File Structure
That one index.js was getting unruly. I've split off the functions to
browser_operations,data_operations, andscaling_operationsto help make contributing easyBye Yarn
Self-explanatory. Moving dependency management full to NPM.
Fixes Bugs
There were two major functional issues with the library: lack of support for multiple images at once and no rejections on errors. These have both been addressed.
Ships With a Test Web App
See the
testsfolder. This Vue CLI app can be used for local development for contributors using the method described in CONTRIBUTINGAdds MIT License
Addresses #37