Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject promise if FileReader or image element encounter error #29

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Reject promise if FileReader or image element encounter error #29

merged 2 commits into from
Oct 13, 2021

Conversation

jasonkit
Copy link
Contributor

This PR is for addressing #28.

@ericnograles
Copy link
Owner

Thanks for the contribution @jasonkit -- I did a recent refactor which also addresses this -- if you have a chance, can you re-test with v2.2.0 and lmk if it behaves as expected? Thanks!

@ericnograles ericnograles mentioned this pull request Mar 23, 2021
Closed
@jasonkit
Copy link
Contributor Author

jasonkit commented Apr 6, 2021

@ericnograles
reviewed, I think it should be fine now.

@ericnograles ericnograles reopened this Oct 13, 2021
@ericnograles ericnograles merged commit e3878b2 into ericnograles:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonkit @ericnograles