Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 952 #954

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Issue 952 #954

merged 2 commits into from
Dec 3, 2018

Conversation

CaseyCarter
Copy link
Collaborator

No description provided.

@CaseyCarter
Copy link
Collaborator Author

CaseyCarter commented Dec 2, 2018

This fixes the symptom - the manifestation in #952, but not the root cause. Removing the exception specifications from range_access::begin_cursor, the view_adaptor::begin_cursor overloads, and view_adaptor::begin_cursor_ also corrects the hard error in #952. Either something is misconstrained in the view_adaptor machinery, or all three compilers are evaluating the exception specifications earlier than they are allowed to.

@CaseyCarter
Copy link
Collaborator Author

CaseyCarter commented Dec 3, 2018

Either something is misconstrained in the view_adaptor machinery

There's an instantiation order dependency: changing the return type of view_adaptor::begin_cursor from adaptor_cursor_t<D> to decltype(adaptor_cursor_t<D>{}) brings the hard error back even with the exception specifications disabled. I'm tempted to simply remove the exception specifications and call it fixed.

@CaseyCarter
Copy link
Collaborator Author

I'm going to merge this, and continue investigating the view_adaptor weirdness as a separate issue.

@CaseyCarter CaseyCarter merged commit b210be7 into ericniebler:master Dec 3, 2018
@CaseyCarter CaseyCarter deleted the issue_952 branch December 3, 2018 05:37
@ericniebler
Copy link
Owner

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants