refactor(web)🛠️: Refactor web app structure and routing #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ericmjl
commented
Nov 17, 2024
ericmjl
commented
- Extract database operations into a separate module for better separation of concerns.
- Create routers for logs and prompt versions to organize endpoint handling.
- Update HTML templates to reflect new routing paths.
- Extract database operations into a separate module for better separation of concerns. - Create routers for logs and prompt versions to organize endpoint handling. - Update HTML templates to reflect new routing paths.
- Modify the get_prompt_functions to include the Request object and use TemplateResponse. - Update the prompt_dropdown.html template to display version counts next to function names.
- Add count of versions next to each function name in dropdowns. - Modify SQL queries to include count of prompt versions. - Update HTML templates to display function names with their respective counts.
|
Feeling good with progress: |
…dency updates - Add experiments router with endpoints for managing ML experiment runs. - Update dependencies in app.py to include new modules and response classes. - Refactor database session handling across routers for consistency. - Integrate experiments data into the main index page for better user navigation.
- Retrieve and display prompt details based on prompt hash in experiment details. - Update experiment details HTML to show prompt function names and hashes. - Add backend support for querying prompt details in the experiments router. - Include new test cases for the added functionality.
- Create a new Runs model to record experiment runs with metadata and data stored in JSON format. - Integrate Runs model with the database upgrade process, ensuring it is created during database initialization. - Refactor experiment details and list endpoints to use the new Runs model, improving data handling and removing redundant code. - Update tests to use the Runs model directly, simplifying setup and improving test reliability.
- Create a new __init__.py file to serve as the top-level API for routers in the llamabot project.
…-multipart - Reformat version constraints for consistency across various packages. - Add python-multipart to dependencies in pyproject.toml.
- Change JSON columns to Text in Runs model to standardize data handling. - Update SQLAlchemy query filter method for better compatibility. - Modify test cases to serialize JSON data for consistency with new column types. - Enhance documentation in experimentation_api notebook for clarity.
…meters - Add required query parameters to the test_client.get call in test_debug_logs.
- Deleted the test_debug_logs function which tested the debug logs endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.