Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mvvm #8

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Mvvm #8

wants to merge 14 commits into from

Conversation

ShilpaSarawagi
Copy link

No description provided.

*
*/
public void mark( int row, int col ) {
public Player mark( int row, int col ) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was really nice!

return playerThatMoved;
}

public Player valueAtCell(int row, int col) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of that method?

@@ -1,3 +1,3 @@
package com.acme.tictactoe.model;

enum Player { X , O }
public enum Player { X , O }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not only used on /model/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants