CLZ optimization #63
Merged
CLZ optimization #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for the PR! I've not see |
|
Saves 256 bytes of flash - Tested on an SE and seemed to work fine. I'll test a few more scenarios this evening before merging. Thanks again. |
erichelgeson
pushed a commit
that referenced
this pull request
Nov 4, 2022
Patches from ============ Improve filename handling (#62, #63) 80228b6c01aa6e95e0060c07e3308f6217021996 GD32: fix reading of very last SD card sector 3c41957068ae87582e3ac65fd4e2a28beebe2b68 Fix spurious read error messages due to prefetch when image is at end… cb6d102435c5c599ed110cb40875626f829699e8 Narrow down error for spec 1.x sd cards 7ed375d8e30f08226703d781b13a9c06777b6042 to 786dffd3476b64882c11f0525b24087354ebc6d6 skipping e7c8fe7293276957b494ffa533fe4c7c2e954ff2 Remove boot flag check from SdFat d004cc3d862a9b2cc7b8575c5833581c65308254
erichelgeson
pushed a commit
that referenced
this pull request
Nov 4, 2022
RP2040: Add support for SCSI-1 single initiator mode (#61)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the selected SCSI ID code to use __builtin_clz to find the first selected bit. This compiles to the ARM CLZ instruction, which is supported on the STM32F103.