Revert "We only need to test 50 and 25 as the rest are just divided and rounded to full and half." #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd rounded to full and half." This reverts commit 1cfaf00.
erichelgeson
force-pushed
the
eric/spiTake3
branch
from
0597a5e
to
dc0bce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1cfaf00.
We can actually run at any SPI speed - some cards run fine at 49 that wont run at 50. Our assumption about how the divisor worked was incorrect and we'd slow the SPI bus too much for no reason.
Removed the warning to the user too - a 25MHz SPI is plenty fast here. Need to still update the troubleshooting docs to take the info in the Slow SPI article into account.