Skip to content

Commit

Permalink
metrics: refactor histogram bucket generation and testing
Browse files Browse the repository at this point in the history
This commit refactors histogram bucketing for legibility
and composibility. It also introduces a data-driven test
for histogram bucket generation.

This refactor should make it easier to add additional
metric categories, distributions, and bucket types.

Part of cockroachdb#97144.

Release note: None
  • Loading branch information
ericharmeling committed Jul 24, 2023
1 parent cdf12cf commit f920b0c
Show file tree
Hide file tree
Showing 12 changed files with 424 additions and 381 deletions.
1 change: 0 additions & 1 deletion pkg/util/metric/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ go_test(
"//pkg/testutils/datapathutils",
"//pkg/testutils/echotest",
"//pkg/util/log",
"@com_github_dustin_go_humanize//:go-humanize",
"@com_github_kr_pretty//:pretty",
"@com_github_prometheus_client_golang//prometheus",
"@com_github_prometheus_client_model//go",
Expand Down
Loading

0 comments on commit f920b0c

Please sign in to comment.