fix: classList.toString don't remove extra whitespace characters #29
Conversation
|
👍 thx. Will merge and publish soon. |
src/getClasses.js
Outdated
|
|
||
| try { | ||
| return Array.from(el.classList); |
There was a problem hiding this comment.
I don't know what this library is supposed to support, but keep in mind that Array.from is absent in some older browsers: https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/from#Browser_compatibility
There was a problem hiding this comment.
Or ... I guess Babel will take care of that?
There was a problem hiding this comment.
No, it will not take care actually, there is not babel-polyfill. Good catch! @ronkorving
@jeetiss Can you pls change it to slice ?
There was a problem hiding this comment.
I added polyfill for Array.from from core-js
Maybe this better solution?
There was a problem hiding this comment.
@jeetiss if we can achieve it without polyfill would be better, to keep the size of the lib as less as possible :)
No description provided.