Limits the number of class-combinations to avoid freeze #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge this. It will fix the freeze when there are many classes on one element. |
| @@ -0,0 +1,31 @@ | |||
| function kCombinations( result, items, data, start, end, index, k ) | |||
There was a problem hiding this comment.
missing jsdoc block
There was a problem hiding this comment.
Ok, will create one.
src/getCombinations.js
Outdated
| /** | ||
| * Returns all the possible selector combinations | ||
| */ | ||
| export function getCombinations( items, k ) |
There was a problem hiding this comment.
pls add jsdoc block (@param, @returns)
| @@ -35,6 +35,15 @@ describe( 'Unique Selector Tests', () => | |||
| expect( uniqueSelector ).to.equal( 'body > :nth-child(1)' ); | |||
| } ); | |||
|
|
|||
| it( 'Classes', () => | |||
There was a problem hiding this comment.
this should explain what is testing.
There was a problem hiding this comment.
Well, I named the tests after your tests which are not any more descriptive than this one either.
There was a problem hiding this comment.
Right, I see, there are not more descriptive indeed. Sorry, I cant remember the codebase, I havent work on the project the last months.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially useful for the modernizr sites which have dozens of classes attached to their
<html>element.