Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to getID() to return null if element has no set id #22

Merged
merged 1 commit into from
Feb 20, 2017
Merged

Add check to getID() to return null if element has no set id #22

merged 1 commit into from
Feb 20, 2017

Conversation

vwochnik
Copy link
Contributor

No description provided.

@vwochnik
Copy link
Contributor Author

This fixes an unseen error where getID() is returning always a string which is being passed to testUniqueness() which will return false but the call is not necessary. There is a check for getID() returning a falsy value but it never does because of the missing condition.

@AvraamMavridis AvraamMavridis merged commit 02d4a42 into ericclemmons:master Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvraamMavridis AvraamMavridis AvraamMavridis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vwochnik @AvraamMavridis