fix: get ID when colon included (#48)

ericclemmons · Oct 13, 2020 · 5d24b11 · 5d24b11
1 parent 6e54106
commit 5d24b11
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/getID.js b/src/getID.js
@@ -9,8 +9,8 @@ export function getID( el )
 
   if( id !== null && id !== '')
   {
-    // if the ID starts with a number selecting with a hash will cause a DOMException
-    return id.match(/^\d/) ? `[id="${id}"]` : '#' + id;
+    // if the ID starts with a number or contains ":" selecting with a hash will cause a DOMException
+    return id.match(/(?:^\d|:)/) ? `[id="${id}"]` : '#' + id;
   }
   return null;
 }
diff --git a/test/unique-selector.js b/test/unique-selector.js
@@ -26,6 +26,15 @@ describe( 'Unique Selector Tests', () =>
     expect( uniqueSelector ).to.equal( '[id="1so"]' );
   } );
 
+  it( 'ID', () =>
+  {
+    $( 'body' ).get( 0 ).innerHTML = ''; //Clear previous appends
+    $( 'body' ).append( '<div id="api:key" class="test3"></div>' );
+    const findNode = $( 'body' ).find( '.test3' ).get( 0 );
+    const uniqueSelector = unique( findNode );
+    expect( uniqueSelector ).to.equal( '[id="api:key"]' );
+  } );
+
   it( 'Class', () =>
   {
     $( 'body' ).get( 0 ).innerHTML = ''; //Clear previous appends