Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 0.11 #33

Merged
merged 1 commit into from
Jul 18, 2014

Conversation

glittershark
Copy link
Contributor

No description provided.

@WickyNilliams
Copy link

👍 keen to move to react 0.11.0

@WickyNilliams
Copy link

Might it be worth setting version to something like ">= 0.11.0" (as is done here in reactify)? That way it won't be tied to a specific version and you won't need to update for each release?

@glittershark
Copy link
Contributor Author

Semver says minor version = potentially breaking change. imo it's best
to conform to that.

On 07/18, Nick Williams wrote:

Might it be worth setting version to "^0.11.0"? That way it will be considered compatible with anything up to 1.0.0 (which, for the most part, is unlikely to have breaking changes)


Reply to this email directly or view it on GitHub:
#33 (comment)

Griffin Smith
[email protected]
(720) 206-7218

@ericclemmons
Copy link
Owner

I thought minor was:

MINOR version when you add functionality in a backwards-compatible manner

So should we use ^0.11.0?

http://fredkschott.com/post/2014/02/npm-no-longer-defaults-to-tildes/

@WickyNilliams
Copy link

See semver.org:

Given a version number MAJOR.MINOR.PATCH, increment the:

MAJOR version when you make incompatible API changes,
MINOR version when you add functionality in a backwards-compatible manner, and
PATCH version when you make backwards-compatible bug fixes.

However, below 1.0.0 everything is considered unstable. For that reason ^ has a special meaning below < 1.0.0. That's explained here: https://www.npmjs.org/doc/misc/semver.html

^0.1.3 := >=0.1.3-0 <0.2.0-0 "Compatible with 0.1.3". 0.x.x versions are special: the first non-zero component indicates potentially breaking changes, meaning the caret operator matches any version with the same first non-zero component starting at the specified version.

@ericclemmons
Copy link
Owner

So ^0.11.0 would match >=0.11.0-0 <0.12.0-0. That's what we'd want, right? It means we'd have to manually bump with each minor react version until they hit 1.0, but that seems right...

You tell me :)

@larsonjj
Copy link

^0.11.0 would be correct. You will have to update the dependency for react again when they hit 0.12.0, but that will ensure that this module will not break anyone's builds on the next update. Not ideal, but it seems to be the correct way to go about it.

@WickyNilliams
Copy link

Yeah i think you're right, >= is too permissive while React is < 1.0.0

@glittershark
Copy link
Contributor Author

I just fixed the PR to use ^0.11.0

@WickyNilliams
Copy link

:shipit:

ericclemmons added a commit that referenced this pull request Jul 18, 2014
@ericclemmons ericclemmons merged commit e8a2089 into ericclemmons:master Jul 18, 2014
@ericclemmons
Copy link
Owner

v0.8.3 is out with it!

Thanks!

@glittershark
Copy link
Contributor Author

Yay, thanks!

@larsonjj
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants