Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path matching issue with usemin on Windows #80

Merged
merged 1 commit into from
Feb 16, 2014

Conversation

christianrondeau
Copy link
Contributor

When you are working with both Windows and Linux, a common solution must be used for how path are compared with usemin:

ngtemplates: {
    dist: {
        options: {
            usemin: 'scripts' + Path.sep + 'scripts.js',
        }
    }
}

It would be better instead to normalize the path specified in the build:js section and compare with the file system result.

Note that tests were not updated because they will not run on Windows (I attempted to fix them quickly but I don't have more time to put on this at the moment)

ericclemmons added a commit that referenced this pull request Feb 16, 2014
Fix path matching issue with usemin on Windows
@ericclemmons ericclemmons merged commit 725846b into ericclemmons:master Feb 16, 2014
@ericclemmons
Copy link
Owner

Thanks! v0.5.2 released!

@christianrondeau
Copy link
Contributor Author

Wonderful! Tested on a Window 8.1 Pro machine and on Heroku successfully!

@ericclemmons
Copy link
Owner

::whew:: I'm glad. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants