Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup tmp cleanup #913

Merged
merged 2 commits into from
Aug 28, 2021
Merged

Conversation

altendky
Copy link
Collaborator

@altendky altendky requested a review from ericaltendorf August 28, 2021 19:15
@altendky altendky changed the base branch from main to development August 28, 2021 19:15
@altendky
Copy link
Collaborator Author

I'm getting file names such as plot-k32-2021-08-28-15-05-0b9e4436b8279739d582e3213277040bc9bea4c40bc72aff552fcda56f775d46.p1.t1.sort_bucket_9.tmp from madMAx anyways. The existing pattern doesn't match this.

@altendky
Copy link
Collaborator Author

And plot-k25-2021-08-28-15-19-2762fbdc8cc76b1e90d646db6e199522fed8ef5db8602b253e2b1fd1854a7263.plot.p1.t1.sort_bucket_079.tmp from chiapos.

@altendky
Copy link
Collaborator Author

err, need a changelog entry

Copy link
Owner

@ericaltendorf ericaltendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. FWIW I'm on board with creating a new directory for each plot job and using that for isolation, then we could use full wildcard.

@altendky
Copy link
Collaborator Author

Yep, that's somewhere on the list...

@altendky altendky merged commit 6197121 into ericaltendorf:development Aug 28, 2021
@altendky altendky deleted the fixup_tmp_cleanup branch August 28, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants